Add ConnectedServer Property to AprsIsClient

[martelro]

Description

As described in #120, a rotating address is often used to connect to an APRS-IS server; however, the actual connected server is not known to the user.

This change adds parsing to the AprsIsClient class to obtain the connected server and expose it as a property of the class.

Changes

• Add nullable public property, ConnectedServer, to AprsIsClient
• Add parsing logic via private method to obtain the server name from the connected server's login response and assign to ConnectedServer. If server name cannot be determined, the property value is set to null.
• Private method also logs server name

Validation

• Build passes
• Created and passed unit tests
• Ran locally at LogInformation visibility level to confirm server name is captured in property

[CBielstein]

This looks really great! Clearly you know your way around the C# stack more than the descriptions gave you credit for. No offense intended there, just never know the experience level and want to be welcoming to newbies as well. 😊

Just caught the one race condition, which I only caught as my PC for some reason fails on it 100% of the time. I wouldn't have seen it otherwise. There are also a few line of test code that came over from the other test but aren't necessary here that we can clean up.

Overall, looks fantastic (especially in a bit of a messy code base like ours 😁)! Please make the little tweaks and I'm excited to merge this in!

[martelro]

Thank you for the kind review. Admittedly, I know some areas of C# better than others, but those will come with time and practice I hope!

I've pushed the updates, but please let me know if there's anything else. Thank you!

[CBielstein]

Perfect! Thanks for the updates and the code in general! You're more than welcome to code with us whenever you'd like! 😎

[CBielstein]

Commenting for my own sake: I did rerun the build task due to test timeout failures, but these were not related to this test. They are a known issue of our parallelism and such issues would be resolved by #125. With that in mind, I'm still merging this PR and we can fix #125 asap to ensure this doesn't happen again.