WeatherInfo parses out comment text #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Day job and "real life" have been busy. I see and appreciate this PR and will make an effort to review soon. Thank you! |
CBielstein
reviewed
Jul 8, 2022
There was a problem hiding this comment.
Thanks for this PR! Love this functionality and can't wait to integrate it in to a little web app I'm working with around this (going public soon, hopefully! 🤞). Thanks for your patience on the review as well, real life was calling...
Just a few questions about approach! Not trying to dictate changes, just curious for thoughts and dialog, so feel free to let me know if what I'm saying isn't the best approach. 😊
|
No worries. Happy 4th!
…On Fri, Jul 1, 2022 at 10:09 AM Cameron Bielstein ***@***.***> wrote:
Day job and "real life" have been busy. I see and appreciate this PR and
will make an effort to review soon. Thank you!
—
Reply to this email directly, view it on GitHub
<#137 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIV3ZRQJSX54YGOVSXQZAJLVR4Q23ANCNFSM5ZJVBHOA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
CBielstein
approved these changes
Dec 20, 2022
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trims the encoded weather measurements from the
WeatherInfoinfo field object. Places the remaining "user" comment into theCommentproperty of theWeatherInfoobject.#105
Changes
*Add
Commentproperty toWeatherInfoclass.PositionInfobase class will still hold the untrimmed comment.*Add logic in
WeatherInfoto determine the consecutive portion of the comment which contains weather measurement data and strips that out of the comment. Weather measurements inside the comment will remain in the user comment and be evaluated as measurements.*Update
PrintPacketto display weather user comment*Modify and create unit tests
Validation
*Build passes
*Passed unit tests for encode/decode
*Ran with live data and confirmed user comment captured as desired