Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove package references to unused nuget packages #151

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Remove package references to unused nuget packages #151

merged 2 commits into from
Jul 11, 2023

Conversation

CBielstein
Copy link
Owner

@CBielstein CBielstein commented Jul 11, 2023 •
edited

Description

There are a few nuget packages that are not referenced or used in the code, though some of the dependencies of the dependencies are used. This removes the unused packages and adds an explicit dependency on what is required.

Changes

  • Remove package reference to unused nuget packages
  • Adds an explicit reference to the correct dependency

Validation

  • Tests pass
  • Linting passes
  • Manually running APRSsharp CLI works

@CBielstein CBielstein added the code cleanliness Refactors, static analysis, etc. label Jul 11, 2023
@CBielstein CBielstein self-assigned this Jul 11, 2023
@CBielstein CBielstein merged commit 4da16b0 into main Jul 11, 2023
3 checks passed
@CBielstein CBielstein deleted the unnecessary-packages branch July 11, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddywine eddywine Awaiting requested review from eddywine eddywine is a code owner

Assignees

@CBielstein CBielstein

Labels
code cleanliness Refactors, static analysis, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@CBielstein