Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new UnsupportedInfo info field type to display unsupported packet types #152

Merged
merged 10 commits into from
Jul 16, 2023

Conversation

CBielstein
Copy link
Owner

Description

Introduces UnsupportedInfo to allow for displaying partial decode and raw (undecoded) info field from packets with an info field that is not supported by APRS#.
Display of these packets is disabled by default in APRSsharp.exe but can be enabled with the new --display-unsupported flag.

UnsupportedInfo cannot be used for encoding in an effort to reduce using APRS# to send non-standard packets that might clutter the network.

Resolves #148.

Changes

  • Add UnsupportedInfo info field
  • Use it for any info field that is not known or supported during packet decode
  • Add display of these new types to APRS# CLI app behind optional --display-unsupported flag
  • Adds new tests

Validation

  • Manually tested against APRSIS to display or not display based on flag in CLI app
  • Added new tests

@CBielstein CBielstein added the enhancement New feature or request label Jul 16, 2023
@CBielstein CBielstein self-assigned this Jul 16, 2023
@CBielstein CBielstein merged commit 7fd9341 into main Jul 16, 2023
3 checks passed
@CBielstein CBielstein deleted the unsupported-info branch July 16, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement UnsupportedInfo object to represent packets with info types not yet implemented
1 participant