Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch TNC communication to bytes instead of strings #153

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Switch TNC communication to bytes instead of strings #153

merged 4 commits into from
Jul 18, 2023

Conversation

CBielstein
Copy link
Owner

@CBielstein CBielstein commented Jul 18, 2023 •
edited

Description

Switches the KISS TNC logic away from sending strings and to sending bytes. Adds tests for TNC implementations.

Resolves #146

Changes

  • Introduces SendBytes method on TNCInterface and implementing classes
  • Update logic to call SendBytes instead of SendString (which now just wraps SendBytes as well)
  • Update TcpTNC to accept an ITcpConnection injected for testing
  • Add TcpTNC tests via refactored TNC tests

Validation

  • Manually ran with direwolf to test TCP connection
  • Tests all pass

@CBielstein CBielstein added bug Something isn't working code cleanliness Refactors, static analysis, etc. labels Jul 18, 2023
@CBielstein CBielstein self-assigned this Jul 18, 2023
@CBielstein CBielstein merged commit 602c60d into main Jul 18, 2023
3 checks passed
@CBielstein CBielstein deleted the kiss-bytes branch July 18, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddywine eddywine Awaiting requested review from eddywine eddywine is a code owner

Assignees

@CBielstein CBielstein

Labels
bug Something isn't working code cleanliness Refactors, static analysis, etc.
Projects
None yet
Milestone
APRS# Can Transmit Packets Using TNC ...
Development

Successfully merging this pull request may close these issues.

Update KISS TNC code to send/receive bytes instead of strings
1 participant
@CBielstein