Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish Shared package #159

Merged
merged 4 commits into from
Aug 5, 2023
Merged

Publish Shared package #159

merged 4 commits into from
Aug 5, 2023

Conversation

CBielstein
Copy link
Owner

@CBielstein CBielstein commented Aug 5, 2023 •
edited

Description

The Shared library needs to be published as both AprsSharp.AprsIsClient and AprsSharp.KissTnc depend on it. Nuget restore step will incorrectly restore a package called Shared. This PR publishes AprsSharp.Shared so that the shared code can be restored and used.

Version is also bumped to 0.3.1.

Changes

  • Declare AprsSharp.Shared as a new package
  • Add pack and publish steps
  • Bump version to 0.3.1

Validation

  • Build succeeds
  • Will release after merge and test restore in a different project

@CBielstein CBielstein added the bug Something isn't working label Aug 5, 2023
@CBielstein CBielstein self-assigned this Aug 5, 2023
@CBielstein CBielstein merged commit a1dc775 into main Aug 5, 2023
4 checks passed
@CBielstein CBielstein deleted the publish-shared branch August 5, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddywine eddywine Awaiting requested review from eddywine eddywine is a code owner

Assignees

@CBielstein CBielstein

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@CBielstein