New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mouse_move event support #138
Conversation
What happens when the window loses focus (e.g. with alt-tab)? |
JFX currently does not work, because I can't figure out how to get a configuration option from the renderer script.
When focus is lost, a |
*/ | ||
public void move(int x, int y) { | ||
if (inTerminal(x, y)) { | ||
queueEvent("mouse_move", new Object[] { x, y }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where's the button arg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mouse_move doesn’t need a button arg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the button argument, it's always 1
.
I don't think it does. This looks completely different. The mouse move throttle is in ticks, not milliseconds. It uses a monotonic clock and not System.currentTimeMillis. It passes a button arg to remain consistent with the other |
See my comments in cc-tweaked/CC-Tweaked#433. |
This completes the second to do task in this pull request. For more information on this topic, please view that PR.
Todo