Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading the dependencies and versions #245

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

andoriyaprashant
Copy link

Fixes #240

Describe the changes you have made in this PR -

There are many updates are available and I upgrade dependencies, I have simultaneously tested with new dependencies, and there were no errors, unlike before when errors were occurring. After upgrading some dependencies to their compatible version, those errors have also been fixed

And I have tested all the dependencies with Flutter version 3.7.11, and all the dependencies are compatible with this version

Screenshots of the changes (If any) -

Screenshot 2023-06-27 174044

  • I upgrade dependencies with the help of "flutter pub upgrade --major -version" command

Screenshot 2023-06-27 173949

Changes in -

Screenshot 2023-06-27 174645

@Akshatji800
Copy link
Member

@andoriyaprashant the Flutter CI is failing and the PR includes some packages which are not useful now after migrating to bloc for example - the package provider is not needed now. Please look into these issues if you want to get the PR merged. Also, next time while resolving the issues in this PR please don't close this PR and raise a new one but makes the necessary changes and update this PR itself. Just google - how to update a PR.

@amitamrutiya
Copy link
Contributor

amitamrutiya commented Jun 29, 2023

@andoriyaprashant, we have upgraded to Flutter version 3.10.5. Please ensure that all dependencies are compatible and functioning correctly with the new Flutter version. So fetch latest changes and update this PR accordingly.

@andoriyaprashant
Copy link
Author

andoriyaprashant commented Jul 4, 2023

@Akshatji800 Sir, as @amitamrutiya2210 has changed the Flutter version, it is now Flutter version 3.10.5. I have ensured that all the changes I made in the dependencies are compatible with the new Flutter version.

The new dependencies-
Screenshot 2023-07-04 171514

image

However, when @amitamrutiya2210 made changes to the Flutter version, some dependencies were duplicated.

Screenshot 2023-07-04 171411

Screenshot 2023-07-04 171422

and flutter ci is failing because of this
image

I have removed those duplicates If you'd like, I can commit these changes, and the changes I made are the same as shown in my screenshot. Please review those changes.
Thank you.

@amitamrutiya
Copy link
Contributor

Yes, @andoriyaprashant, please remove the duplicate dependencies and commit the changes. In the new commit, make sure to remove the pubspec.yaml file as it is not necessary for this issue.

@andoriyaprashant
Copy link
Author

Hey @amitamrutiya2210 As you mentioned, I have removed the duplicate changes.
However, by mistake, this commit got pushed to the branch in my forked repository.

Screenshot 2023-07-04 200703

You can see this commit in the commit graph, but I'm unable to display it in this pull request. Could you please assist me with resolving this issue?

@amitamrutiya
Copy link
Contributor

Try with this command git push origin flood2 -f. I think this has to work.

@andoriyaprashant
Copy link
Author

andoriyaprashant commented Jul 4, 2023

@amitamrutiya2210 Sorry but still not working with "git push origin flood2 -f"
When I was working on this same branch, I committed the changes and used "git push --force origin flood2 " command. Now those changes are not appearing in the code of the "flood2" branch as well, but my commit is visible in commit graph.

@andoriyaprashant
Copy link
Author

Hey @amitamrutiya2210 @Akshatji800 I have implemented the changes you requested, and now Flutter CI is not failing. So, could you please review my pull request now
Thank you so much for your support

@amitamrutiya
Copy link
Contributor

amitamrutiya commented Jul 8, 2023

@andoriyaprashant, Before merging the pull request, you need to ensure two things in your PR:

  1. Remove the pubspec.lock file from your commits. This is not necessary for this particular PR.
  2. Squash all commits into a single one.

If you are unsure about these steps, simply search for them on Google. These tasks are easy to figure out.

@Akshatji800
Copy link
Member

@andoriyaprashant the Flutter CI is still failing and also please look into what @amitamrutiya2210 asked you do in his previous comment to get this PR merged.

@andoriyaprashant
Copy link
Author

@Akshatji800 Thank you, I will definitely work on this.

@amitamrutiya
Copy link
Contributor

@andoriyaprashant, please make sure to pull the latest changes before making any new commits.

@andoriyaprashant
Copy link
Author

Hello sir @Akshatji800 , I'm a little confused and would appreciate your guidance.
So far, I have only upgraded dependencies, and the last time the Flutter CI failed because there were duplicate dependencies, which I removed in a subsequent commit titled "flutter ci fixed." Now, you mentioned making changes to the pubspec.yaml file, but I'm unsure about what to do next. I have already upgraded all the dependencies according to the Flutter version. Could you please provide further instructions? Thank you so much for your support.

@Akshatji800
Copy link
Member

Hello sir @Akshatji800 , I'm a little confused and would appreciate your guidance. So far, I have only upgraded dependencies, and the last time the Flutter CI failed because there were duplicate dependencies, which I removed in a subsequent commit titled "flutter ci fixed." Now, you mentioned making changes to the pubspec.yaml file, but I'm unsure about what to do next. I have already upgraded all the dependencies according to the Flutter version. Could you please provide further instructions? Thank you so much for your support.

@andoriyaprashant why you are still including the pubspec.lock file in the commit and if you are including then resolve the conflicts.

@andoriyaprashant
Copy link
Author

Sir @Akshatji800 as you mentioned, I have resolved the conflicts from the pubspec.lock file, and I have also squashed all the commits. Please take a look once, and if there are still any conflicts, I will be happy to resolve them.
Thank you

@andoriyaprashant
Copy link
Author

@Akshatji800 Sir, can you review it again now?

@Akshatji800
Copy link
Member

Akshatji800 commented Aug 13, 2023

image
@andoriyaprashant everytime I come and try to review this PR and give approval to run the CI I find some or the other reason for the build to be failing :/ . Make sure you resolve the issue and none of the build failes next time so that we can finalize this PR.

@andoriyaprashant
Copy link
Author

@Akshatji800 Sorry sir, I am currently learning about workflows, but as you advised, I have made the changes in it. Please take a look at them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

To update all dependencies and version of This project
3 participants