Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new default icons for selected default labels + filter counter for overview in drawer #174

Closed
wants to merge 3 commits into from

Conversation

Rushour0
Copy link

@Rushour0 Rushour0 commented Oct 27, 2022

Added default label icons
Made a new enum type - DefaultLabels which maps to the respective png files
A new default label can be added in DefaultLabels, with its corresponding png file in assets/icons with the same name as the label

Example :
label: videos
filename: videos.png

Added a class DefaultPaths
The intelli-sense can make it faster to write these paths, than having to remember them.

Example:
normal string path: assets/icons/
with DefaultPaths: DefaultPaths.defaultLabelIcons

The variable can be autocompleted with intellisense and reduces the need to remember the path if the variables are well named

solution to issue #108
label-icon-filter-screenshot

@Rushour0
Copy link
Author

New function addition in the torrent service to count the torrents by filter
All counts of the filters are now visible in the drawer
issue #109 solution

label-count-screenshot

@Rushour0 Rushour0 changed the title new default icons for selected default labels new default icons for selected default labels + filter counter for overview in drawer Oct 27, 2022
@Rushour0
Copy link
Author

Rushour0 commented Jan 4, 2023

@nb9960 can you check these updates?

@Rushour0
Copy link
Author

Rushour0 commented Jan 8, 2023

@AbdulMalikDev can you review this?

@Rushour0
Copy link
Author

@AbdulMalikDev can you please check this PR

@AbdulMalikDev
Copy link
Collaborator

@Rushour0 Please make a PR to the develop branch. Once we have enough changes and testing done we'll merge with main. Till then, I am closing this PR.

@Rushour0
Copy link
Author

Rushour0 commented Mar 4, 2023

@Rushour0 Please make a PR to the develop branch. Once we have enough changes and testing done we'll merge with main. Till then, I am closing this PR.

Alright, will do it right away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants