[WIP] style/refactor: mode state management issue in main screen #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: the entire widget tree was being rerendered and updated on mode state change
rj-since-2000
force-pushed
the
state_management
branch
from
35c4786
to
fddc3a7
Compare
|
@harchani-ritik All merge conflicts have been resolved and commits squashed. Please let me know any changes required. |
|
@rj-since-2000 Is this change only required on the main screen? |
rj-since-2000
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83
fix: entire widget tree was being updated on mode state change, removed the
Consumer<Mode>from the root of the tree and addedProvider<Mode>accordingly