table made responsive #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the PR to fix the aligment issues, and the "broken" html near the table element. |
|
can you please specify what are the alignment issues? |
|
|
templates/test/list_table.html
Outdated
| <th title="Did the test suite finish or error out?">Completed</th> | ||
| {% if tests|length > 0 %} | ||
| <div id="no-more-tables"> | ||
| <table class="col-md-12 table-bordered table-striped table-condensed cf"> |
|
That's looking all good, but could you now fix the conflict between the master and your PR in app.css? |
|
ok i will fix the conflict |
|
@satyammittal Try fetch and rebase instead of pull. It results in a cleaner commit history :) . Also, I think you can |
|
I definitely am going to squash that :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In mobiles:
In desktop:
Table become list in small devices.
p.s.: sorry for the random data placed inside the table.
Responsiveness of the platform - pt. 2 #35