Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waiting tag added in the filter section #343

Merged
merged 6 commits into from
May 16, 2024

Conversation

BrawlerXull
Copy link
Contributor

@BrawlerXull BrawlerXull commented May 11, 2024

Description

Added waiting tag in the filter section.

Fixes #(issue_no)

#337

Screenshots

This is a demo UI
Screenshots are explained in below comments.

Screenshot 1 Screenshot 2
Screenshot 3 Screenshot 4 Screenshot 5

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

@BrawlerXull
Copy link
Contributor Author

This is just an demo UI I'll be creating a good one when these changes are reviewed

@BrawlerXull
Copy link
Contributor Author

Explanation of the screenshots

Here I've created 3 tasks

  1. With waiting time not set
  2. With waiting time set less than current time.
  3. With waiting time more than current time.

The waiting in the filters acts like a toggle
When it is on
Only 1 task is shown i.e. task with waiting time more than current time
When it is off
2 Tasks are shown i.e task in which waiting time is not entered or it is less than current time.

@BrawlerXull
Copy link
Contributor Author

BrawlerXull commented May 13, 2024

Screen.Recording.2024-05-16.at.2.23.22.AM.mov

Final UI Implementation of the feature

@Pavel401 Pavel401 merged commit 28962a0 into CCExtractor:main May 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants