-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
...and remove the old start/stop/show console calls. The client library, cli, and tests still need to be updated.
Some bitrot apparently.
Two unused imports that I missed when updating stuff
Ok, tests are passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Things we would need to update in the next PR
[ ] Remove all old code
[ ] Update the API docs
[ ] Upade the config files (sample, and dev-no-hardware).
for the next release of HIL we should also include the call to get power status.
so an API for
[ ] get power status API.
[ ] Make a new obmd release
Line 136 in c4057f7
On a related node, how does this line of code even work in our tests. As far as I know we the url to enable the obm (which returns the token) is obmd_uri/node/<node-name>/token . But in that method we just do obmd_uri/path where path is just token in this case.
This is what I did locally to get it working:
But how are the integration tests passing then |
The |
ah, I forgot about that bit. I did the registration wrong in that case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
hil/client/node.py
Outdated
url = self.object_url('node', node, 'console') | ||
response = self.httpClient.request('GET', url) | ||
# we don't call check_response here because we want to return the | ||
# raw byte stream, rather than converting it to json. | ||
# raw byte stream, rather reading the whole thing in and converting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than *
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
...pointed out by @ianballou
This is the last API call that actually uses the drivertized API support. A subsequent PR will delete the old functionality.
Still futzing with travis; I'm getting an error in the CLI tests that I can't reproduce locally.