Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds documentation on CSV loading #114

Merged
merged 3 commits into from
Feb 29, 2024
Merged

adds documentation on CSV loading #114

merged 3 commits into from
Feb 29, 2024

Conversation

jmbhughes
Copy link
Contributor

This resolves #64 by adding a new documentation page that outlines the CSV format required for loading packets.

I'm open to any suggestions to improve clarity.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.05%. Comparing base (f3957b6) to head (7d11be5).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   95.75%   96.05%   +0.29%     
==========================================
  Files           7        7              
  Lines         707      710       +3     
==========================================
+ Hits          677      682       +5     
+ Misses         30       28       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddasilva
Copy link
Collaborator

Thanks for submitting @jmbhughes ! I'll take a look at this over the weekend.

@ddasilva
Copy link
Collaborator

Thanks so much @jmbhughes! I think this looks pretty good. I made some suggestions to improve readability of the documentation. Having this page on the website will be good motivation for us to make the CSV format more feature complete (e.g., #115).

@jmbhughes
Copy link
Contributor Author

These changes all look good to me. I'll make them ASAP.

@jmbhughes
Copy link
Contributor Author

@ddasilva I updated with the suggested changes, so it's good to go.

@ddasilva ddasilva merged commit 1522816 into CCSDSPy:main Feb 29, 2024
8 checks passed
@ddasilva
Copy link
Collaborator

Merged. Thanks @jmbhughes !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for CSV File Packet Definition
2 participants