Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOQUS Cloud: fixing OUU bug #1001

Merged
merged 2 commits into from Feb 22, 2022
Merged

Conversation

sotorrio1
Copy link
Member

Trying to fix issue #999

@sotorrio1 sotorrio1 self-assigned this Jan 18, 2022
@sotorrio1 sotorrio1 added bug 💣 Label denoting that specific functions/buttons within modules, and imported plugins are not working. FOQUS Cloud Issues specific to FOQUS Cloud. OUU Issues related to the errors, and results after OUU Flowsheet Issues related to setting up, & running process models for simulation in the Flowsheet tab labels Jan 18, 2022
@sotorrio1 sotorrio1 linked an issue Jan 18, 2022 that may be closed by this pull request
@lbianchi-lbl lbianchi-lbl self-requested a review February 8, 2022 20:56
@lbianchi-lbl
Copy link
Contributor

The fix should work and we'd like to have it in, but it'd be nice if we could have a test for this. I'll check if I can quickly implement a test that can reproduce the error, and if not, we should just merge this fix.

Copy link
Contributor

@lbianchi-lbl lbianchi-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #1001 (8d3d5ee) into master (b49f7f9) will decrease coverage by 0.02%.
The diff coverage is 10.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1001      +/-   ##
==========================================
- Coverage   30.25%   30.23%   -0.03%     
==========================================
  Files         160      160              
  Lines       35564    35596      +32     
  Branches     5996     6012      +16     
==========================================
+ Hits        10759    10761       +2     
- Misses      24018    24047      +29     
- Partials      787      788       +1     
Impacted Files Coverage Δ
foqus_lib/gui/flowsheet/dataBrowserFrame.py 43.52% <10.41%> (-5.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b49f7f9...8d3d5ee. Read the comment docs.

@lbianchi-lbl lbianchi-lbl added this to In progress in 2022 March Release via automation Feb 22, 2022
@lbianchi-lbl lbianchi-lbl moved this from In progress to Done in 2022 March Release Feb 22, 2022
@lbianchi-lbl lbianchi-lbl merged commit 040a9dd into CCSI-Toolset:master Feb 22, 2022
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Mar 8, 2022
@sotorrio1 sotorrio1 deleted the issue-999 branch September 2, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 💣 Label denoting that specific functions/buttons within modules, and imported plugins are not working. Flowsheet Issues related to setting up, & running process models for simulation in the Flowsheet tab FOQUS Cloud Issues specific to FOQUS Cloud. OUU Issues related to the errors, and results after OUU Priority:High High Priority Issue or PR
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

FOQUS Cloud: OUU bugs
3 participants