Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for bugs related to SDOE in 3.21-rc #1210

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

kbuma
Copy link
Contributor

@kbuma kbuma commented Mar 26, 2024

Fixes/Addresses:

Summary/Motivation:

Fix bugs that are present in RC as related to SDOE UX

Changes proposed in this PR:

  • pin matplotlib between 3.6.0 and 3.7.5 (<3.6 doesn't have wheels for python 3.11 and 3.8 introduces the issue with the plotting of results)
  • fix setValue that was missed previously

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@kbuma kbuma requested a review from lbianchi-lbl March 26, 2024 18:58
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 38.79%. Comparing base (1161d04) to head (bb64069).

Files Patch % Lines
foqus_lib/gui/sdoe/sdoeAnalysisDialog.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1210      +/-   ##
==========================================
+ Coverage   38.76%   38.79%   +0.02%     
==========================================
  Files         164      164              
  Lines       37032    37032              
  Branches     6132     6132              
==========================================
+ Hits        14354    14365      +11     
+ Misses      21550    21536      -14     
- Partials     1128     1131       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Mar 26, 2024
@ksbeattie ksbeattie self-requested a review March 26, 2024 20:01
@kbuma
Copy link
Contributor Author

kbuma commented Mar 26, 2024

This was the error related to matplotlib:

Traceback (most recent call last):
  File "C:\ProgramData\anaconda3\envs\ccsi-foqus-rc\lib\site-packages\foqus_lib\gui\sdoe\sdoePreview.py", line 149, in plotSdoe
    fig1, fig2 = plot_utils.plot(
  File "C:\ProgramData\anaconda3\envs\ccsi-foqus-rc\lib\site-packages\foqus_lib\framework\sdoe\plot_utils.py", line 509, in plot
    fig1 = plot_candidates(
  File "C:\ProgramData\anaconda3\envs\ccsi-foqus-rc\lib\site-packages\foqus_lib\framework\sdoe\plot_utils.py", line 421, in plot_candidates
    lh.set_alpha(1)
  File "C:\ProgramData\anaconda3\envs\ccsi-foqus-rc\lib\site-packages\matplotlib\collections.py", line 848, in set_alpha
    artist.Artist._set_alpha_for_array(self, alpha)
  File "C:\ProgramData\anaconda3\envs\ccsi-foqus-rc\lib\site-packages\matplotlib\artist.py", line 1033, in _set_alpha_for_array
    Artist.set_alpha(self, alpha)
  File "C:\ProgramData\anaconda3\envs\ccsi-foqus-rc\lib\site-packages\matplotlib\artist.py", line 1015, in set_alpha
    if alpha != self._alpha:
ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()```

ksbeattie
ksbeattie previously approved these changes Mar 26, 2024
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sotorrio1 sotorrio1 self-requested a review March 26, 2024 20:22
setup.py Show resolved Hide resolved
lbianchi-lbl
lbianchi-lbl previously approved these changes Mar 27, 2024
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kbuma for reporting and fixing these errors.

@lbianchi-lbl lbianchi-lbl merged commit 47053af into CCSI-Toolset:master Mar 27, 2024
8 of 9 checks passed
lbianchi-lbl pushed a commit that referenced this pull request Mar 27, 2024
* restricting matplotlib due to issues when using 3.8

* cast parameter for setValue to int

* Add link to #1211

---------

Co-authored-by: Ludovico Bianchi <lbianchi@lbl.gov>
(cherry picked from commit 47053af)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants