-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for bugs related to SDOE in 3.21-rc #1210
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1210 +/- ##
==========================================
+ Coverage 38.76% 38.79% +0.02%
==========================================
Files 164 164
Lines 37032 37032
Branches 6132 6132
==========================================
+ Hits 14354 14365 +11
+ Misses 21550 21536 -14
- Partials 1128 1131 +3 ☔ View full report in Codecov by Sentry. |
This was the error related to matplotlib:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kbuma for reporting and fixing these errors.
- From a quick text search in the FOQUS codebase for
.setValue(
, I wasn't able to spot any "visiblyfloat
-y" left after https://github.com/lbianchi-lbl/FOQUS/blob/1a92aa769fd95ab0e0ad9301bb40735318f28da1/foqus_lib/gui/sdoe/sdoeAnalysisDialog.py#L852. - We should aim at making sure that this part of the code is covered by tests, but in the meantime we should merge this fix
Fixes/Addresses:
Summary/Motivation:
Fix bugs that are present in RC as related to SDOE UX
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: