Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cart is always emptied with every payment #2

Closed
ghost opened this issue Jul 29, 2021 · 2 comments
Closed

Cart is always emptied with every payment #2

ghost opened this issue Jul 29, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jul 29, 2021

The cart is always emptied when starting a new payment. When users go back to the webshop with the back button of the browser they will see an empty cart and will need to start all over again.

The cart should only be emptied when the payment was marked as completed. That way users will be able to restart payments without having to search for their products in the webshop again.

in WC_CcvOnlinePayments_Gateway.php there is this section:

$woocommerce->cart->empty_cart()

This issue is probably linked to #1 where the wrong assumption is made that every payment is a bank transfer that needs to be manually checked.

@PeterCmdc
Copy link
Collaborator

Thanks for the detailed report.

Fixing this issue depends on #1, because the cart is also cleared by setting the status to 'on-hold'.

@PeterCmdc PeterCmdc added the bug Something isn't working label Aug 2, 2021
@PeterCmdc PeterCmdc self-assigned this Aug 2, 2021
@PeterCmdc
Copy link
Collaborator

This should be fixed in v1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant