Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

world coordinate do not respect datawc_x1/x2 #1849

Closed
doutriaux1 opened this issue Feb 20, 2016 · 2 comments
Closed

world coordinate do not respect datawc_x1/x2 #1849

doutriaux1 opened this issue Feb 20, 2016 · 2 comments
Assignees
Milestone

Comments

@doutriaux1
Copy link
Contributor

@danlipsa we need urgently to fix the datawc_x1/x2/y1/y2 issue this affects I isolated the issue (in meshfill at least which appear in: PCMDI/pcmdi_metrics#296 ) to be coming from: https://github.com/UV-CDAT/uvcdat/blob/master/Packages/vcs/Lib/vcsvtk/meshfillpipeline.py#L53

Looking at the issue above when runnig it with the EXACT same template and datawc_x1/x2 4 times but slightly different "mesh" coordinatesI get:

MESH: -0.5 15.5 0.0 9.5
MESH: -0.5 15.0 -0.5 9.5
MESH: -0.5 15.5 -0.5 9.0
MESH: 0.0 15.5 -0.5 9.5

which leads to the ugglyness in the issues (ticks offsets, triangle on top of each others)

Another example would be:

import cdms2
import vcs
f=cdms2.open(vcs.sample_data+"/sampleCurveGrid4.nc")
s=f("sample")
x=vcs.init()
m=x.createmeshfill()
m.datawc_x1 = -20
m.datawc_x2 = 20
m.datawc_y1 = -20
m.datawc_y2 = 20
x.plot(s,m)
x.png("bad")

png, far from being the requested bounds

bad

@danlipsa
Copy link
Contributor

@doutriaux1 Could I get the original script/data from PCMDI/pcmdi_metrics#296? I have seen and solved something similar for plots of boxfill + vector. There, the bounds for boxfill data were slightly larger than the bounds for vector the vector which resulted in similar duplication of labels.

danlipsa added a commit that referenced this issue Feb 23, 2016
For datasets using a geographic projection, datawc
is only used to specify wrapping (translation of the origin,
for instance from 0:360 to -180:180) and flipping.
@danlipsa
Copy link
Contributor

@doutriaux1 @aashish24 Does this fix the issue?
#1855

danlipsa added a commit that referenced this issue Feb 24, 2016
For datasets using a geographic projection, datawc
is only used to specify wrapping (translation of the origin,
for instance from 0:360 to -180:180) and flipping.
danlipsa added a commit that referenced this issue Feb 24, 2016
For datasets using a geographic projection, datawc
is only used to specify wrapping (translation of the origin,
for instance from 0:360 to -180:180) and flipping.
doutriaux1 added a commit that referenced this issue Feb 24, 2016
BUG #1849: Re-enable datawc for linear projection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants