Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vistrails message at the end. #26

Closed
doutriaux1 opened this issue Dec 1, 2012 · 4 comments
Closed

vistrails message at the end. #26

doutriaux1 opened this issue Dec 1, 2012 · 4 comments
Assignees
@benbu
Labels
Enhancement VisTrails wontfix

Comments

@doutriaux1
Copy link
Contributor

Everytime Vistrails quits it asks if we want to save "unsaved changes". It would be nice to have an option in the lines of "remember my choice" so that we can always quit w/o asking.
@ghost ghost assigned benbu Dec 1, 2012
@dakoop
Copy link
Contributor

dakoop commented Dec 3, 2012

I don't understand why anyone would want this. Most applications ask about saving if you have unsaved changes for a reason---they don't want to throw away a user's work if that user quit without realizing that some of their changes were not saved.

@doutriaux1
Copy link
Contributor Author

Because sometime you just want to look at the data not really do anything with it. It's just a pain to click close twce. Maybe we can just automatically save for the user.

From: dakoop <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Monday, December 3, 2012 1:43 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: "Doutriaux, Charles" <doutriaux1@llnl.govmailto:doutriaux1@llnl.gov>
Subject: Re: [uvcdat] vistrails message at the end. (#26)

I don't understand why anyone would want this. Most applications ask about saving if you have unsaved changes for a reason---they don't want to throw away a user's work if that user quit without realizing that some of their changes were not saved.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/26#issuecomment-10973330.

@dakoop
Copy link
Contributor

dakoop commented Dec 4, 2012

I agree that in some cases, the user will not want to save anything, and you are correct that a quick analysis to see what a particular dataset looks like will often be one of them. I just fear an option that never asks the user to save if they close a modified analysis. Personally, I am happy to click the "Don't Save" button 99 times if it saves me the 100th time. Auto-save could be an option here, but you can run into issues where a user didn't want things saved and is surprised by the state when returning to a particular analysis (even though they could go back using the provenance).

@doutriaux1
Copy link
Contributor Author

Or you could just save it to some vt with the date in it, and simply let the user "reload it" if he really wanted to. Probably would need some options for how many "auto-save" file we want to keep.

C.

From: dakoop <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Tuesday, December 4, 2012 12:06 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: "Doutriaux, Charles" <doutriaux1@llnl.govmailto:doutriaux1@llnl.gov>
Subject: Re: [uvcdat] vistrails message at the end. (#26)

I agree that in some cases, the user will not want to save anything, and you are correct that a quick analysis to see what a particular dataset looks like will often be one of them. I just fear an option that never asks the user to save if they close a modified analysis. Personally, I am happy to click the "Don't Save" button 99 times if it saves me the 100th time. Auto-save could be an option here, but you can run into issues where a user didn't want things saved and is surprised by the state when returning to a particular analysis (even though they could go back using the provenance).

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/26#issuecomment-11013424.

doutriaux1 pushed a commit that referenced this issue Apr 30, 2013
This will fix ticket 177. The problem was that the invalid value
5c0f1bc 
was inconsistent with the mask value (ie it should have been
missing_value but was something else).

Hence, the regridder no longer solely relies on the missing value to
determine the mask, an extra copy is made to ensure that mask and
missing_value are consistent before applying the interpolation
coefficients.

All regridding tests pass on idefix.

[11:58][pletzer@idefix:~/build-uvcdat]$ ctest
Test project /home/pletzer/build-uvcdat
      Start  1: run_uvcdat
 1/58 Test  #1: run_uvcdat .........................***Failed    6.60 sec
      Start  2: cdms_test
 2/58 Test  #2: cdms_test ..........................***Failed    3.81 sec
      Start  3: cdms_verify
 3/58 Test  #3: cdms_verify ........................***Failed    2.46 sec
      Start  4: test177_regrid_mask
 4/58 Test  #4: test177_regrid_mask ................   Passed    2.23 sec
      Start  5: testMPIGrid
 5/58 Test  #5: testMPIGrid ........................   Passed    6.26 sec
      Start  6: testDoutriaux
 6/58 Test  #6: testDoutriaux ......................   Passed    2.99 sec
      Start  7: testMarvel
 7/58 Test  #7: testMarvel .........................   Passed    1.25 sec
      Start  8: testUnits
 8/58 Test  #8: testUnits ..........................   Passed    2.34 sec
      Start  9: testRaynaud
 9/58 Test  #9: testRaynaud ........................   Passed   74.79 sec
      Start 10: testDateline
10/58 Test #10: testDateline .......................   Passed    1.20 sec
      Start 11: testEsmfInit4Pes
11/58 Test #11: testEsmfInit4Pes ...................   Passed    1.31 sec
      Start 12: testImports
12/58 Test #12: testImports ........................   Passed    0.86 sec
      Start 13: testDiag
13/58 Test #13: testDiag ...........................   Passed   13.53 sec
      Start 14: testSo2TasACCESSFails
14/58 Test #14: testSo2TasACCESSFails ..............   Passed    1.58 sec
      Start 15: testSo2Tas
15/58 Test #15: testSo2Tas .........................   Passed    4.51 sec
      Start 16: testWrite
16/58 Test #16: testWrite ..........................   Passed    7.60 sec
      Start 17: testMvCdmsRegrid
17/58 Test #17: testMvCdmsRegrid ...................   Passed    5.07 sec
      Start 18: testLibCFLevelAndTime
18/58 Test #18: testLibCFLevelAndTime ..............   Passed    9.54 sec
      Start 19: testMpi10Pes
19/58 Test #19: testMpi10Pes .......................   Passed    1.57 sec
      Start 20: testRemoteGet8Pes
20/58 Test #20: testRemoteGet8Pes ..................   Passed    3.18 sec
      Start 21: testUnstructGrid
21/58 Test #21: testUnstructGrid ...................   Passed    0.93 sec
      Start 22: testConserv
22/58 Test #22: testConserv ........................   Passed   40.00 sec
      Start 23: testEsmfVsLibcf
23/58 Test #23: testEsmfVsLibcf ....................   Passed   48.78 sec
      Start 24: testEsmfInterface1
24/58 Test #24: testEsmfInterface1 .................   Passed   10.94 sec
      Start 25: testEsmfInterface2Pes
25/58 Test #25: testEsmfInterface2Pes ..............   Passed   64.44 sec
      Start 26: testDistArray6Pes
26/58 Test #26: testDistArray6Pes ..................   Passed    1.41 sec
      Start 27: testGhostedDistArray6Pes
27/58 Test #27: testGhostedDistArray6Pes ...........   Passed    1.45 sec
      Start 28: testDistTransientVar6Pes
28/58 Test #28: testDistTransientVar6Pes ...........   Passed    5.64 sec
      Start 29: testEsmfGridToMeshRegridCsrv
29/58 Test #29: testEsmfGridToMeshRegridCsrv .......   Passed    4.61 sec
      Start 30: testEsmf3DSmallNative
30/58 Test #30: testEsmf3DSmallNative ..............   Passed    2.33 sec
      Start 31: testEsmf3DSmallNative2Pes
31/58 Test #31: testEsmf3DSmallNative2Pes ..........   Passed    6.66 sec
      Start 32: testEsmf3DSmallesmf
32/58 Test #32: testEsmf3DSmallesmf ................   Passed    2.32 sec
      Start 33: testEsmf3DSmallesmf2Pes
33/58 Test #33: testEsmf3DSmallesmf2Pes ............   Passed    4.66 sec
      Start 34: testGridTypes
34/58 Test #34: testGridTypes ......................   Passed    2.71 sec
      Start 35: testEsmfSmall
35/58 Test #35: testEsmfSmall ......................   Passed    2.23 sec
      Start 36: testEsmfSmall2Pes
36/58 Test #36: testEsmfSmall2Pes ..................   Passed    2.48 sec
      Start 37: testEsmfSmall4Pes
37/58 Test #37: testEsmfSmall4Pes ..................   Passed    3.10 sec
      Start 38: testEsmfSmall8Pes
38/58 Test #38: testEsmfSmall8Pes ..................   Passed    5.64 sec
      Start 39: testTasRegrid
39/58 Test #39: testTasRegrid ......................   Passed    1.78 sec
      Start 40: testTasRegrid2Pes
40/58 Test #40: testTasRegrid2Pes ..................   Passed    3.30 sec
      Start 41: testCltRegrid
41/58 Test #41: testCltRegrid ......................   Passed    3.13 sec
      Start 42: testRegrid2
42/58 Test #42: testRegrid2 ........................   Passed    2.25 sec
      Start 43: testRegrid2Tool
43/58 Test #43: testRegrid2Tool ....................   Passed    1.37 sec
      Start 44: testEsmf_3x4_6x8_Conserve
44/58 Test #44: testEsmf_3x4_6x8_Conserve ..........   Passed    1.63 sec
      Start 45: testEsmf_3x4_6x8_Bilinear
45/58 Test #45: testEsmf_3x4_6x8_Bilinear ..........   Passed    1.60 sec
      Start 46: testEsmf_3x4_6x8_Conserve_Masked
46/58 Test #46: testEsmf_3x4_6x8_Conserve_Masked ...   Passed    3.76 sec
      Start 47: testEsmf_3x4_6x8_Bilinear_Masked
47/58 Test #47: testEsmf_3x4_6x8_Bilinear_Masked ...   Passed    2.30 sec
      Start 48: testMvGenericRegrid
48/58 Test #48: testMvGenericRegrid ................   Passed    7.51 sec
      Start 49: testSalinity
49/58 Test #49: testSalinity .......................   Passed    7.52 sec
      Start 50: testEsmfSalinity
50/58 Test #50: testEsmfSalinity ...................   Passed   15.23 sec
      Start 51: testEsmfSalinity2Pes
51/58 Test #51: testEsmfSalinity2Pes ...............   Passed    9.82 sec
      Start 52: testEsmfSalinity4Pes
52/58 Test #52: testEsmfSalinity4Pes ...............   Passed    8.09 sec
      Start 53: testEsmfSalinity8Pes
53/58 Test #53: testEsmfSalinity8Pes ...............   Passed   11.33 sec
      Start 54: testEsmf
54/58 Test #54: testEsmf ...........................   Passed    4.72 sec
      Start 55: testBergman
55/58 Test #55: testBergman ........................   Passed    2.23 sec
      Start 56: testDistSrc
56/58 Test #56: testDistSrc ........................   Passed   12.52 sec
      Start 57: testDistSrc4Pes
57/58 Test #57: testDistSrc4Pes ....................   Passed    6.41 sec
      Start 58: testReverseOrderInterp
58/58 Test #58: testReverseOrderInterp .............   Passed    1.50 sec

95% tests passed, 3 tests failed out of 58

Total Test time (real) = 471.08 sec

The following tests FAILED:
	  1 - run_uvcdat (Failed)
	  2 - cdms_test (Failed)
	  3 - cdms_verify (Failed)
Errors while running CTest
[2]+  Done                    emacs Testing/Temporary/LastTest.log
@williams13 williams13 mentioned this issue Sep 10, 2014
Closed
danlipsa added a commit that referenced this issue Oct 27, 2016
@danlipsa
Add test for BUG #26: If masking reduces the bounds of a dataset, plo…
c26f39f 
…ts look incomplete.
doutriaux1 pushed a commit that referenced this issue Nov 2, 2016
@danlipsa @doutriaux1
Add test for BUG #26: If masking reduces the bounds of a dataset, plo…
25a3e66 
…ts look incomplete. (#2134)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benbu benbu

Labels
Enhancement VisTrails wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chaosphere2112 @benbu @dakoop @doutriaux1