Made slider jump instead of animate, added test #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aashish24 @doutriaux1 Please review, no testdata update to go with, just a behavioral test. |
|
works for me AND the vtk_ui test actually passes as well (the other ones still seg fault sadly) |
doutriaux1
added a commit
that referenced
this pull request
Apr 9, 2015
Made slider jump instead of animate, added test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made sliders jump to clicked positions instead of animating; it was super slow and annoying. To test, plot a variable, start interact, and open up the animation submenu from the configure menu. Open the time slider, and click on the slider anywhere besides the slide toggle. It should jump straight there.