Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vtk refactor #1229

Merged
merged 4 commits into from May 6, 2015
Merged

Vtk refactor #1229

merged 4 commits into from May 6, 2015
+1,694 −739

Commits on May 5, 2015

  1. Add checkFuzzyBoolean representation. 

    This should probably replace the other similar functions for
consistency on the backend, but this works for now.
    David C. Lonie committed May 5, 2015
    Configuration menu
    Copy the full SHA
    63f64f1 View commit details
    Browse the repository at this point in the history

  2. Add vcsvtk.Pipeline interface, ported VTKPlots.plot2D to use it. 

    This change shouldn't affect external behavior at this point, but
just organizes the code and separates the logic for different plot
types to make the implementations more robust to changes and easier
to read/follow/debug.

The Pipeline class is an interface for interacting with VTK. At this
point, it defines a single virtual method, plot(...), which takes
arguments similar to VTKPlots.plot(...). It still returns the
undocumented map with objects that are reused for animations, so
that code should continue to function as before.

This patch:

- Creates initial Pipeline interface.
- Add shared logic from Plot2D into Pipeline2D subclass.
- Adds specific implementations as Boxfill-, Isoline-, Isofill-, and
  MeshfillPipeline subclasses.
- Cleans up style to conform to PEP 8.
- Reraise exception in new boxfill test when it makes sense (made it
  easier to track down why the test was failing.)
- Creates vcs2vtk.isTrue(...) to perform consistent user_input-->bool
  conversions.
    David C. Lonie committed May 5, 2015
    Configuration menu
    Copy the full SHA
    7416eab View commit details
    Browse the repository at this point in the history

  3. Add vectorpipeline plots to vcsvtk submodule.

    David C. Lonie committed May 5, 2015
    Configuration menu
    Copy the full SHA
    8090db5 View commit details
    Browse the repository at this point in the history

  4. Add Pipeline1D.

    David C. Lonie committed May 5, 2015
    Configuration menu
    Copy the full SHA
    5798113 View commit details
    Browse the repository at this point in the history