New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newdiagstes charles #1238

Merged
merged 19 commits into from Apr 28, 2015

Conversation

Projects
None yet
4 participants
@doutriaux1
Member

doutriaux1 commented Apr 27, 2015

No description provided.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Apr 27, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Apr 27, 2015

@aashish24 @painter1 should get tests passing, difficult ones have been commented out for this release

@painter1 don't forget to move tag point for metrics once this is in

mcenerney1 and others added some commits Apr 27, 2015

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Apr 28, 2015

I am looking into it now.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Apr 28, 2015

@doutriaux1 please avoid appending names to the branches 😄

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Apr 28, 2015

1/5 Test #60: vcs_test_dump_taylordiagram ...... Passed 0.84 sec
Start 388: diags_test_01
2/5 Test #388: diags_test_01 ....................***Failed 0.91 sec
Start 389: diags_test_03
3/5 Test #389: diags_test_03 .................... Passed 3.90 sec
Start 390: diags_test_04
4/5 Test #390: diags_test_04 .................... Passed 3.43 sec
Start 391: diags_test_41
5/5 Test #391: diags_test_41 .................... Passed 3.27 sec

80% tests passed, 1 tests failed out of 5

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Apr 28, 2015

Hey all, one test is failing but this is an improvement so I am going ahead and merging.

aashish24 added a commit that referenced this pull request Apr 28, 2015

@aashish24 aashish24 merged commit 8f8d330 into master Apr 28, 2015

0 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/kitware-buildbot Build done.
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@aashish24 aashish24 deleted the newdiagstesCharles branch Apr 28, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Apr 28, 2015

@aashish24 agreed on branch names but in the interest of both time and babysitting non-git experts that's what we came up with 😉

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Apr 28, 2015

@doutriaux1 that's fine but I don't think naming a branch should take more than 5 minutes right? I am not picking on anyone but just wanted to make sure that I point out these kinds of things to ensure best practices. Please do the same to me because sometimes I do the same as well.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Apr 28, 2015

@aashish24 ok. But I actually don't have 5 mn! 30sec is the most I can spend on naming a branch!

@doutriaux1 doutriaux1 added this to the 2.2 milestone Apr 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment