New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newdiagstes charles #1238
Newdiagstes charles #1238
Conversation
…ewdiagtest Conflicts: testing/metrics/CMakeLists.txt
goes with: CDAT/uvcmetrics#114 and CDAT/uvcdat-testdata#39 |
@aashish24 @painter1 should get tests passing, difficult ones have been commented out for this release @painter1 don't forget to move tag point for metrics once this is in |
I am looking into it now. |
@doutriaux1 please avoid appending names to the branches 😄 |
1/5 Test #60: vcs_test_dump_taylordiagram ...... Passed 0.84 sec 80% tests passed, 1 tests failed out of 5 |
Hey all, one test is failing but this is an improvement so I am going ahead and merging. |
@aashish24 agreed on branch names but in the interest of both time and babysitting non-git experts that's what we came up with 😉 |
@doutriaux1 that's fine but I don't think naming a branch should take more than 5 minutes right? I am not picking on anyone but just wanted to make sure that I point out these kinds of things to ensure best practices. Please do the same to me because sometimes I do the same as well. |
@aashish24 ok. But I actually don't have 5 mn! 30sec is the most I can spend on naming a branch! |
No description provided.