Add flake8 test for xmgrace. #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
had to avoid __init__.py
|
@aashish24 @dlonie @sankhesh 1 done! Many to go 😉 |
|
You are awesome @doutriaux1 Did you use some tool to fix most of these? |
|
@dlonie @sankhesh I will have you review it |
|
The warning should be properly fixed, or the specific line excluded. Let's not change the directory-level scanning. |
|
ok it's in. I left the import * because I don't want to risk breaking anything by forgetting an import. This module is pretty much legacy anyway now, I don't think anybody new to uvcdat would pick this up, it's mainly for our current/past users. |
|
LGTM |
alliepiper
pushed a commit
that referenced
this pull request
Jul 7, 2015
Add flake8 test for xmgrace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test currently fails. The code needs to be cleaned up before merging.
@doutriaux1 @aashish24