Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8 test for xmgrace. #1421

Merged
merged 5 commits into from Jul 7, 2015
Merged

Add flake8 test for xmgrace. #1421

merged 5 commits into from Jul 7, 2015

Conversation

alliepiper
Copy link
Contributor

The test currently fails. The code needs to be cleaned up before merging.

@doutriaux1 @aashish24

@doutriaux1
Copy link
Contributor

@aashish24 @dlonie @sankhesh 1 done! Many to go 😉

@aashish24
Copy link
Contributor

You are awesome @doutriaux1 Did you use some tool to fix most of these?

@aashish24
Copy link
Contributor

@dlonie @sankhesh I will have you review it

@alliepiper
Copy link
Contributor Author

The warning should be properly fixed, or the specific line excluded. Let's not change the directory-level scanning.

@doutriaux1
Copy link
Contributor

ok it's in. I left the import * because I don't want to risk breaking anything by forgetting an import. This module is pretty much legacy anyway now, I don't think anybody new to uvcdat would pick this up, it's mainly for our current/past users.

@alliepiper
Copy link
Contributor Author

LGTM

alliepiper pushed a commit that referenced this pull request Jul 7, 2015
Add flake8 test for xmgrace.
@alliepiper alliepiper merged commit 14ec096 into master Jul 7, 2015
@alliepiper alliepiper deleted the flake8-xmgrace branch July 7, 2015 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants