Issue 1396 bad png path #1556
Merged
Issue 1396 bad png path #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4812,6 +4812,9 @@ def png(self, file, width=None, height=None, | |||
| a.plot(array) | |||
| a.png('example') # Overwrite a png file | |||
| """ | |||
| base = os.path.dirname(file) | |||
| if base!="" and not os.path.exists(base): | |||
| raise vcsError("Output path: %s does not exists" % base) | |||
There was a problem hiding this comment.
@doutriaux1 "does not exists" -> "does not exist"
| @@ -4812,6 +4812,9 @@ def png(self, file, width=None, height=None, | |||
| a.plot(array) | |||
| a.png('example') # Overwrite a png file | |||
| """ | |||
| base = os.path.dirname(file) | |||
There was a problem hiding this comment.
Why not put this block of code in try catch instead of checking of the file exists? In general thats a better practice
There was a problem hiding this comment.
Because it does not fail, that is actually the issue.
There was a problem hiding this comment.
@aashish24 are you suggesting we create the subdirectory?
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.