New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes git_update.sh handle detached heads #835

Merged
merged 1 commit into from Oct 22, 2014

Conversation

Projects
None yet
3 participants
@remram44
Contributor

remram44 commented Oct 21, 2014

git symbolic-ref HEAD will fail in detached head mode.

@remram44 remram44 added the Build label Oct 21, 2014

@remram44 remram44 added this to the 2.1 milestone Oct 21, 2014

@remram44

This comment has been minimized.

Contributor

remram44 commented Oct 21, 2014

Doesn't fix #837

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Oct 22, 2014

LGTM

aashish24 added a commit that referenced this pull request Oct 22, 2014

Merge pull request #835 from remram44/git-update
Makes git_update.sh handle detached heads

@aashish24 aashish24 merged commit 7f6b49d into CDAT:master Oct 22, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

@remram44 remram44 deleted the remram44:git-update branch Oct 22, 2014

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Oct 22, 2014

@remram44 should have we merge this if it doesn't fix #837 ?

@remram44

This comment has been minimized.

Contributor

remram44 commented Oct 22, 2014

It fixes the case where the repository is in detached-head (such as, after checking out a tag), so it should be merged in. But it doesn't fix updating if @branch@ is a tag -- a patch will be needed for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment