Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issu#136 region #22

Merged
merged 18 commits into from Feb 6, 2018
Merged

Issu#136 region #22

merged 18 commits into from Feb 6, 2018

Conversation

dnadeau4
Copy link
Contributor

@dnadeau4 dnadeau4 commented Feb 5, 2018

No description provided.

@dnadeau4
Copy link
Contributor Author

dnadeau4 commented Feb 5, 2018

travis is failing due to "Ruby" will try to rebuild when Travis fix it.

@dnadeau4 dnadeau4 requested a review from doutriaux1 Feb 6, 2018
@dnadeau4
Copy link
Contributor Author

dnadeau4 commented Feb 6, 2018

We can no longer use the "... since 0" as unit since year 0 is not CF-1 compliant. I changed all tests and test_file th_yr.nc to reflect this. This is a python 3 issue.

@dnadeau4
Copy link
Contributor Author

dnadeau4 commented Feb 6, 2018

I also warned the users about the select_region and created a tests for ticket #22

@dnadeau4
Copy link
Contributor Author

dnadeau4 commented Feb 6, 2018

CDAT/cdms#136


language: python

python:
Copy link
Contributor

@doutriaux1 doutriaux1 Feb 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnadeau4 why do we need this? Does it run the test twice now?

Copy link
Contributor Author

@dnadeau4 dnadeau4 Feb 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it from UV-CDAT.

Copy link
Contributor Author

@dnadeau4 dnadeau4 Feb 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed python 3.6 since we already do both version in the conda env.

Copy link
Contributor Author

@dnadeau4 dnadeau4 Feb 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doutriaux1 Can you merge it?

@doutriaux1 doutriaux1 merged commit 77d37fb into master Feb 6, 2018
@doutriaux1 doutriaux1 deleted the issu#136_region branch Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants