Skip to content

Issu#136 region#22

Merged
doutriaux1 merged 18 commits intomasterfrom
issu#136_region
Feb 6, 2018
Merged

Issu#136 region#22
doutriaux1 merged 18 commits intomasterfrom
issu#136_region

Conversation

@dnadeau4
Copy link
Copy Markdown
Contributor

@dnadeau4 dnadeau4 commented Feb 5, 2018

No description provided.

@dnadeau4
Copy link
Copy Markdown
Contributor Author

dnadeau4 commented Feb 5, 2018

travis is failing due to "Ruby" will try to rebuild when Travis fix it.

@dnadeau4 dnadeau4 requested a review from doutriaux1 February 6, 2018 00:16
@dnadeau4
Copy link
Copy Markdown
Contributor Author

dnadeau4 commented Feb 6, 2018

We can no longer use the "... since 0" as unit since year 0 is not CF-1 compliant. I changed all tests and test_file th_yr.nc to reflect this. This is a python 3 issue.

@dnadeau4
Copy link
Copy Markdown
Contributor Author

dnadeau4 commented Feb 6, 2018

I also warned the users about the select_region and created a tests for ticket #22

@dnadeau4
Copy link
Copy Markdown
Contributor Author

dnadeau4 commented Feb 6, 2018

CDAT/cdms#136

Comment thread .travis.yml

language: python

python:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnadeau4 why do we need this? Does it run the test twice now?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it from UV-CDAT.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed python 3.6 since we already do both version in the conda env.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doutriaux1 Can you merge it?

@doutriaux1 doutriaux1 merged commit 77d37fb into master Feb 6, 2018
@doutriaux1 doutriaux1 deleted the issu#136_region branch February 6, 2018 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants