New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created development install script #67
Conversation
} | ||
trap 'handle_error $LINENO ${BASH_LINENO[@]}' ERR | ||
|
||
CONDA_EXE="$(which conda)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@William-Hill does this work if conda is a function rather than a actual executable (remember issue you had where cdat_info
couldn't find your conda
executable for provenance?
|
||
CONDA_EXE="$(which conda)" | ||
$CONDA_EXE create -y -n jupyter-vcdat3 -c cdat/label/v81 -c conda-forge nodejs "python>3" vcs jupyterlab pip nb_conda nb_conda_kernels plumbum | ||
CONDA_BASE=$(conda info --base) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what these line do since conda
is assumed to be in your path from path, sourcing conda.sh wont help much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to source the conda.sh as a workaround because the conda executable was not being found in the child process that the script was running in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@William-Hill that's my point, how can CONDA_EXE="$(which conda)"
or CONDA_BASE=$(conda info --base)
work then if it doesn't find the executable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it can find the executable, but not the activate function as mentioned here: conda/conda#7980 (comment)
That's what I used as a reference for my workaround. Sourcing conda.sh makes the activate function available to the process that the script is running in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the explanation, let's merge.
Moved the development install steps into a single script. Updated the README