-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
541 patterns support #1516
541 patterns support #1516
Conversation
Incorrect indentation.
Great stuff @sankhesh can you get rid of "WIP" from commit messages? |
@@ -336,6 +355,7 @@ def __init__(self, Tf_name=None, Tf_name_src='default'): | |||
self._style = ['solid', ] | |||
self._index = [1, ] | |||
self._color = [1, ] | |||
self._opacity = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we default to 1. ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. The default is different in different cases.
For solids and patterns, default opacity value is 0 and for hatches it is 100.
6df42e6
to
8f82acf
Compare
@@ -329,6 +343,7 @@ def _plotInternalCustomBoxfill(self): | |||
I = [indices[i]] | |||
tmpLevels.append(L) | |||
tmpColors.append(C) | |||
print tmpLevels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left over?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot. I'll fix it.
@sankhesh I'm excited. Going to play with it right way! quick question does iso.script("iso.json") work? I don't see you updated the test_dump_json and it should probably fail now since we have a new attribute. |
I will let @aashish24 do the "commits police" work 😜 |
@sankhesh also could you please rebase on master? |
@aashish24 Done. @doutriaux1 Until now, I had no idea about the json stuff. I'll take a look at it too. |
They are automatically computed
This is required as patterns/hatches are textures applied to 3D polydata that don't get exported without rasterization.
instead of 4 times the bounds of the pattern plane. This improves performance and also fixes disorientation of texture coordinates with very large textures
Call fitToViewport on object instead of weakref. Build vtkImagingStencil module with VTK.
8f82acf
to
6490f95
Compare
Conflicts: CMake/cdat_modules/vtk_external.cmake Packages/vcs/Lib/VTKPlots.py Packages/vcs/Lib/vcsvtk/isofillpipeline.py testing/matplotlib/CMakeLists.txt
@sankhesh lots of failing tests... Also basic plot now fails: import os,sys,cdms2,vcs
f=cdms2.open(os.path.join(vcs.sample_data,"clt.nc"))
s=f("clt")
x=vcs.init()
x.plot(s)
|
@doutriaux1 Could you please try with a new checkout? I had to force-push a couple of changes. |
@sankhesh looks like you still have 52 tests failing. Most of the has the same pattern. |
Fixed bug where the number of opacity values was one less than the number of colors provided
Fix issue where the set methods allowed setting null or NoneType values for members, thereby causing inconsistencies in code that used these member variables.
This is a special case as the default opacity values differ based on the fill style. The default is 0 for patterns and 100 for solid fill and hatches.
@doutriaux1 All regressions pass now. |
@sankhesh are there some missing files in the test-suite? On the macbot I see:
|
Those files are sitting in a PR @ CDAT/uvcdat-testdata#61 |
@sankhesh awesome dude!.. |
Fixes issues #541 #1042