Skip to content

Commit

Permalink
Makes modal buttons the consistent throughout the app. (medium size, …
Browse files Browse the repository at this point in the history
…right side, primary color for save)
  • Loading branch information
James-Crean committed May 17, 2018
1 parent 76fdfab commit b639c34
Show file tree
Hide file tree
Showing 7 changed files with 18 additions and 21 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class RenameVariable extends Component{
</FormGroup>
</Modal.Body>
<Modal.Footer>
<Button bsStyle="primary" bsSize="small"
<Button bsStyle="primary"
onClick={() => {
if (this.state.temporaryRedefinedVariableName) {
this.doneRedefineVariable();
Expand All @@ -35,7 +35,7 @@ class RenameVariable extends Component{
});
}
}}>Confirm</Button>
<Button bsSize="small" onClick={() => this.setState({ showRedefineVariableModal: false })}>Close</Button>
<Button onClick={() => this.setState({ showRedefineVariableModal: false })}>Close</Button>
</Modal.Footer>
</Modal>
<Dialog ref="dialog" />
Expand Down
12 changes: 6 additions & 6 deletions frontend/src/js/components/modals/CachedFiles/Tabs/FileTab.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -483,16 +483,16 @@ class FileTab extends Component {
}
</Modal.Body>
<Modal.Footer>
<Button bsStyle="primary" bsSize="small" onClick={(e) => {
<Button bsStyle="primary" onClick={(e) => {
this.load()
}}>Load</Button>
<Button bsStyle="primary" bsSize="small" onClick={(e) => {
<Button bsStyle="primary" onClick={(e) => {
this.loadAndClose()
}}>Load and Close</Button>
<Button bsStyle="primary" bsSize="small" onClick={(e) => {
<Button bsStyle="primary" onClick={(e) => {
this.loadAs()
}}>Load As</Button>
<Button bsStyle="default" bsSize="small" onClick={() => this.props.onTryClose()}>Close</Button>
<Button bsStyle="default" onClick={() => this.props.onTryClose()}>Close</Button>
</Modal.Footer>
<Modal show={this.state.showRedefineVariableModal}>
<Modal.Header>
Expand All @@ -508,7 +508,7 @@ class FileTab extends Component {
</FormGroup>
</Modal.Body>
<Modal.Footer>
<Button bsStyle="primary" bsSize="small"
<Button bsStyle="primary"
onClick={() => {
if (this.state.temporaryRedefinedVariableName) {
this.doneRedefineVariable();
Expand All @@ -518,7 +518,7 @@ class FileTab extends Component {
});
}
}}>Confirm</Button>
<Button bsSize="small" onClick={() => this.setState({ showRedefineVariableModal: false })}>Close</Button>
<Button onClick={() => this.setState({ showRedefineVariableModal: false })}>Close</Button>
</Modal.Footer>
</Modal>
{this.state.showFileInfoModal &&
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ class ColormapEditor extends Component {
onClick={() => {this.handleApplyColormap()}}>
Apply
</Button>
<Button onClick={() => {this.saveColormap(this.state.selected_colormap_name)}}>Save</Button>
<Button onClick={() => {this.saveColormap(this.state.selected_colormap_name)}} bsStyle="primary">Save</Button>
<Button onClick={this.openImportExportModal.bind(this)}>Import/Export</Button>
<Button onClick={this.props.close}>Close</Button>
</Modal.Footer>
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/js/components/modals/EditVariable.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,8 @@ class EditVariable extends Component {
}
</Modal.Body>
<Modal.Footer>
<Button id="edit-var-save" bsStyle="default" bsSize="small" onClick={() => this.save()}>Save</Button>
<Button id="edit-var-close" bsStyle="default" bsSize="small" onClick={() => this.props.onTryClose()}>Close</Button>
<Button id="edit-var-save" bsStyle="primary" onClick={() => this.save()}>Save</Button>
<Button id="edit-var-close" bsStyle="default" onClick={() => this.props.onTryClose()}>Close</Button>
</Modal.Footer>
</Modal>
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class FileInfoModal extends Component{
</div>
</Modal.Body>
<Modal.Footer>
<Button id="infotab-close" bsStyle="default" bsSize="small" onClick={() => this.props.onTryClose()}>Close</Button>
<Button id="infotab-close" bsStyle="default" onClick={() => this.props.onTryClose()}>Close</Button>
</Modal.Footer>
</Modal>
)
Expand Down
7 changes: 3 additions & 4 deletions frontend/src/js/components/modals/GraphicsMethodEditor.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React, { Component } from 'react'
import PropTypes from 'prop-types'
import widgets from 'vcs-widgets'
import $ from 'jquery'
import {Modal, ButtonToolbar, Button} from 'react-bootstrap'
import {Modal, Button} from 'react-bootstrap'

class GraphicsMethodEditor extends Component {
constructor(props){
Expand Down Expand Up @@ -37,14 +37,13 @@ class GraphicsMethodEditor extends Component {
updateGraphicsMethod={this.updateGraphicsMethod} />
</Modal.Body>
<Modal.Footer>
<ButtonToolbar>
<Button onClick={this.props.onHide}>Cancel</Button>
<Button
bsStyle="primary"
onClick={() => {
this.props.updateGraphicsMethod(this.state.workingGraphicsMethod); this.props.onHide()
}}>Save
</Button>
</ButtonToolbar>
<Button onClick={this.props.onHide}>Cancel</Button>
</Modal.Footer>
</Modal>
);
Expand Down
8 changes: 3 additions & 5 deletions frontend/src/js/components/modals/TemplateEditor.jsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, { Component } from 'react'
import PropTypes from 'prop-types'
import { Modal, ButtonToolbar, Button } from 'react-bootstrap'
import { Modal, Button } from 'react-bootstrap'
import widgets from 'vcs-widgets'
import PubSub from 'pubsub-js'
import PubSubEvents from '../../constants/PubSubEvents.js'
Expand Down Expand Up @@ -68,10 +68,8 @@ class TemplateEditor extends Component {
}
</Modal.Body>
<Modal.Footer>
<ButtonToolbar>
<Button onClick={this.props.close}>Cancel</Button>
<Button onClick={this.saveTemplate}>Save</Button>
</ButtonToolbar>
<Button onClick={this.saveTemplate} bsStyle="primary">Save</Button>
<Button onClick={this.props.close} bsStyle="default">Cancel</Button>
</Modal.Footer>
</Modal>
);
Expand Down

0 comments on commit b639c34

Please sign in to comment.