Skip to content

Commit

Permalink
fix #397 needed to store continent value (#398)
Browse files Browse the repository at this point in the history
* fix #397 needed to store continent value

* trying to get correct pkg in for build to work (works on my mac)

* typo

* sphinx-autoapi conflicts and i don't think we need it
  • Loading branch information
doutriaux1 committed Apr 1, 2019
1 parent 364e114 commit d86a55d
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ aliases:
if [[ $PY_VER = "py2" ]]; then
conda create -q -n $PY_VER $CUSTOM_CHANNELS $CHANNELS $PKGS $TEMP_PKGS "python<3"
else
conda create -q -n $PY_VER $CUSTOM_CHANNELS $CHANNELS $PKGS $TEMP_PKGS "python=3.6" nbsphinx easydev $COVERAGE_PKGS
conda create -q -n $PY_VER $CUSTOM_CHANNELS $CHANNELS $PKGS $TEMP_PKGS "python=3.6" sphinxcontrib-websupport nbsphinx easydev $COVERAGE_PKGS
fi
- &setup_vcs
Expand Down
9 changes: 9 additions & 0 deletions tests/test_vcs_update_triggers_continents.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import basevcstest

class TestVCSTextsExtents(basevcstest.VCSBaseTest):
def testUpdateDoesNotTriggerContinents(self):
s = self.clt["clt"][0]
self.x.plot(s, continents=0)
self.x.setcolormap("viridis")
self.checkImage("test_vcs_update_triggers_continents.png")

2 changes: 2 additions & 0 deletions vcs/Canvas.py
Original file line number Diff line number Diff line change
Expand Up @@ -4054,6 +4054,8 @@ def __plot(self, arglist, keyargs):
dn.g_name = arglist[4]
dn.array = arglist[:2]
dn.backend = returned_kargs
if "continents" in keyargs:
dn._continents = keyargs["continents"]
else:
dn = None

Expand Down

0 comments on commit d86a55d

Please sign in to comment.