Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trim attributes to number of lines plotted, fix #32 #33

Merged
merged 4 commits into from
Oct 4, 2018
Merged

trim attributes to number of lines plotted, fix #32 #33

merged 4 commits into from
Oct 4, 2018

Conversation

doutriaux1
Copy link
Contributor

quick fix for Peter. He was setting too many linecolors

@coveralls
Copy link

coveralls commented Oct 3, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 157

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 64.464%
Totals Coverage Status
Change from base Build 141: 0.003%
Covered Lines: 1317
Relevant Lines: 2043
💛 - Coveralls

@doutriaux1
Update .travis.yml
b5363dc 
use cdatforgw on travis as well
@doutriaux1
Copy link
Contributor Author

doutriaux1 commented Oct 3, 2018 •
edited
Loading

@dnadeau4 @muryanto1 using the cdat-forge channel fixes it. That's the very reason I created the channel try to decouple us from conda-forge when these nightmares arise.

@muryanto1
Copy link
Member

Changes to .circleci/config.yml looks good.
I tried running your branch on my Mac, and tests passed.
Looks good to merge.

@doutriaux1 doutriaux1 merged commit 8af0752 into master Oct 4, 2018
@doutriaux1 doutriaux1 deleted the 32_toomanyitems branch October 4, 2018 12:57
@doutriaux1 doutriaux1 added this to the 8.1 milestone Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durack1 durack1 Awaiting requested review from durack1

@danlipsa danlipsa Awaiting requested review from danlipsa

@scottwittenburg scottwittenburg Awaiting requested review from scottwittenburg

@muryanto1 muryanto1 Awaiting requested review from muryanto1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doutriaux1 @coveralls @muryanto1