Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow no reads to start #19

Closed
nbx0 opened this issue Jun 15, 2023 · 4 comments
Closed

Allow no reads to start #19

nbx0 opened this issue Jun 15, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@nbx0
Copy link
Collaborator

nbx0 commented Jun 15, 2023

reformat.sh crashes snakemake if run on an empty fastq. Empty fastq can be generated from cat step when fastq_pass/barcodeXX directory exists and there are no fastqs within it. I assume the directory was created by Minknow but that all of barcodeXX reads were put in fastq_fail. Not sure...

@nbx0 nbx0 added the bug Something isn't working label Jun 15, 2023
@kristinelacek
Copy link
Collaborator

I have handling for this in the ONT on-prem snakemake. Basically when the yaml is created, empty fastq_pass dirs are never included in the DAG. The script prints out all the failed barcodes and includes them in the "analyses beginning" email notification. This is, I assume, not the intended behavior for a GUI like MIRA since we still want to show said samples in our figures/etc?

@nbx0
Copy link
Collaborator Author

nbx0 commented Jun 21, 2023 via email

@kristinelacek
Copy link
Collaborator

nbx0/spyne#32

@kristinelacek
Copy link
Collaborator

This MR pulls my empty barcode dir branch into illumina-flu branch (big boy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants