Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-7795] Annotations #1334

Merged
merged 53 commits into from
Jun 12, 2024
Merged

[DEV-7795] Annotations #1334

merged 53 commits into from
Jun 12, 2024

Conversation

adamdoe
Copy link
Collaborator

@adamdoe adamdoe commented Jun 7, 2024

No description provided.

@adamdoe adamdoe added this to the 4.24.6 milestone Jun 7, 2024
@@ -0,0 +1,18 @@
.cdc-open-viz-module .annotation__desktop-label {
display: none;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does .d-none bootstrap class not work here?

Copy link
Collaborator

@mpallansch mpallansch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things I've seen during testing. I'm not sure how the features are supposed to work, so these may not be real issues, feel free to ignore:

  1. Opacity slider doesn't seem to change anything for me
  2. Connection location doesn't seem to change anything
  3. Changing the connection type and connection location and then using snap to location can create gaps between the points
  4. Tooltips seem to interfere with drag and drop functionality

@adamdoe adamdoe merged commit a344c8a into dev Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants