Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing figures in demos. #110

Merged
merged 2 commits into from
May 9, 2024

Conversation

gvegayon
Copy link
Member

@gvegayon gvegayon commented May 8, 2024

This is a minor fix (but important). It seems that Quarto has issues converting files to RST format. Python qmd figures should have the following:

  1. Explicitly plot the figure using plot.show().
  2. Have the code-chunk label with no empty spaces and starting with the fig prefix.
  3. Have a caption.

Here is an example:

#| label: fig-plot-hospital-admissions
#| fig-cap: Daily hospital admissions from the simulated data
...
plt.show()

If either of these three is not fulfilled, Quarto+sphinx don't process the document correctly.

@gvegayon gvegayon linked an issue May 8, 2024 that may be closed by this pull request
3 tasks
@gvegayon gvegayon marked this pull request as ready for review May 8, 2024 22:15
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.01%. Comparing base (d12d2d1) to head (e82e55b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files          34       34           
  Lines         664      664           
=======================================
  Hits          611      611           
  Misses         53       53           
Flag Coverage Δ
unittests 92.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gvegayon gvegayon merged commit 55c8468 into main May 9, 2024
8 checks passed
@gvegayon gvegayon deleted the 91-silence-numpyros-warning-about-cpu-instead-of-gpu branch May 9, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silence numpyro's warning about CPU instead of GPU
1 participant