Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding code coverage workflow #64

Merged
merged 13 commits into from
Apr 4, 2024

Conversation

gvegayon
Copy link
Member

@gvegayon gvegayon commented Apr 3, 2024

  • Adds coverage report via pytest-cov.
  • Sets up codecov.io and uploads report.
  • Adds a badge to README.md
  • Renames existing workflows to have shorter badge names.

@gvegayon gvegayon linked an issue Apr 3, 2024 that may be closed by this pull request
2 tasks
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

dylanhmorris
dylanhmorris previously approved these changes Apr 4, 2024
Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I somewhat preferred the more verbose test_model.yaml and test_pipeline.yaml names for the workflow files, but I am open to this change, and I won't block this on that account alone. Everything else looks good.

@gvegayon
Copy link
Member Author

gvegayon commented Apr 4, 2024

I somewhat preferred the more verbose test_model.yaml and test_pipeline.yaml names for the workflow files, but I am open to this change, and I won't block this on that account alone. Everything else looks good.

No strong opinion on that, so I'll revert it before merge.

@dylanhmorris dylanhmorris merged commit ca96421 into main Apr 4, 2024
7 checks passed
@dylanhmorris dylanhmorris deleted the gvegayon/dev/5-set-gha-for-checking-code-coverage branch April 4, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set GHA for checking code coverage
3 participants