Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create shared resource #1887

Merged
merged 30 commits into from
Jun 11, 2024
Merged

Create shared resource #1887

merged 30 commits into from
Jun 11, 2024

Conversation

nickbristow
Copy link
Collaborator

PULL REQUEST

Summary

Creates a shared resource for use in the ECR viewer and beyong

Related Issue

Fixes #1863

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@@ -132,7 +132,7 @@ const ECRViewerPage: React.FC = () => {
</Grid>
</Grid>
</GridContainer>
<AccordionContainer
<AccordionContent
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this renaming

@nickbristow nickbristow added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit d145dd9 Jun 11, 2024
45 checks passed
@nickbristow nickbristow deleted the 1863/shared-accordion branch June 11, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move accordion components to a a shared components folder
2 participants