Correct h2 and h3 Sizes #2265
Merged
Correct h2 and h3 Sizes #2265
+28
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sarahtress this is ready for review. Can you also have a look at the eCR Summary headers ("Patient Summary", "Encounter Summary", and "Condition Summary")? I had to change their CSS to fix the "eCR Document". |
JNygaard-Skylight
requested review from
BobanL,
angelathe,
lina-roth and
gordonfarrell
|
@JNygaard-Skylight just seeing some alignment/padding issues. I'm going to mark up where I see issues on the screenshots, and then hopefully you can investigate the designs in dev mode to get all of the exact measurements? let me know
|
|
@sarahtress I fixed the margins and double checked the font sizes: |
|
looks good to me! |
BobanL
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Corrected the size of "eCR Document". It should now use the same styling as the other
<h2>"eCR Summary". In addition, fixed the headers within the eCR Summary to correctly be<h3>s instead of<h2>s.Related Issue
Fixes #2170
Additional Information
Anything else the review team should know?
Checklist