Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove org.apache.log4j:1.2.17.2 from build chain #14092

Closed
david-navapbc opened this issue Apr 18, 2024 · 3 comments · Fixed by #14123
Closed

remove org.apache.log4j:1.2.17.2 from build chain #14092

david-navapbc opened this issue Apr 18, 2024 · 3 comments · Fixed by #14123
Labels
High Priority Issue State label to flag an issue that is a high priority platform Platform Team

Comments

@david-navapbc
Copy link
Collaborator

david-navapbc commented Apr 18, 2024

dependency-check-report.html.zip

synopsis

Attached is the report generated by OWASP Dependency Check, invoked as a gradle plugin, for the project. The benefit of invocation by way of the build system is the tool is able to detect more than through build file or artifact analysis alone.

In this case, it detected plugin org.jetbrains.dokka:1.9.20 is bringing in org.apache.log4j:1.2.17.2 which has a ton of nasty security defects associated with it including malicious code execution and network shenanigans. Here is where the plugin is referenced in the build file.

To be clear - the vulnerable dependency is brought in ONLY during the build process by a gradle plugin. It is NOT present in the deliverable.

My view is that this is not of immediate concern, but, we should get this out of our build chain. It's end-of-life known vulnerable code that serves no purpose other than to grow risk.

ACs

your mission, should you choose to accept it, is to remove the reference to org.apache.log4j:1.2.17.2 from the project. This can be accomplished by removing the dokka plugin alltogether. This can also be accomplished by forcing the build chain to use a different logger. The current version of that plugin in maven central is 1.9.20 - so bumping the version is not an option.

@david-navapbc david-navapbc added the platform Platform Team label Apr 18, 2024
@arnejduranovic arnejduranovic added the ready-for-grooming Ticket is a point where we can productively discuss it label Apr 18, 2024
@snesm snesm mentioned this issue Apr 19, 2024
9 tasks
@arnejduranovic arnejduranovic added the High Priority Issue State label to flag an issue that is a high priority label Apr 22, 2024
@Andrey-Glazkv
Copy link
Collaborator

@Andrey-Glazkv
Copy link
Collaborator

Please add your planning poker estimate with Zenhub @david-navapbc

@david-navapbc
Copy link
Collaborator Author

david-navapbc commented Apr 22, 2024

#14123

PR for this in flight

@Andrey-Glazkv Andrey-Glazkv removed the ready-for-grooming Ticket is a point where we can productively discuss it label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority Issue State label to flag an issue that is a high priority platform Platform Team
Projects
Development

Successfully merging a pull request may close this issue.

3 participants