Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back dokka to 1.8.20. #14123

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Roll back dokka to 1.8.20. #14123

merged 3 commits into from
Apr 22, 2024

Conversation

snesm
Copy link
Collaborator

@snesm snesm commented Apr 19, 2024

This PR rolls back dokka to 1.8.20.

Dokka 1.9.20 includes a vulnerable version of log4j.

If you are suggesting a fix for a currently exploitable issue, please disclose the issue to the prime-reportstream team directly outside of GitHub instead of filing a PR, so we may immediately patch the affected systems before a disclosure. See SECURITY.md/Reporting a Vulnerability for more information.

Test Steps:

  1. Include steps to test these changes

Changes

  • Include a comprehensive list of changes in this PR
  • (For web UI changes) Include screenshots/video of changes

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Linked Issues

To Be Done

Create GitHub issues to track the work remaining, if any

  • #issue

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints?
    • new endpoint A
    • new endpoint B
  • Does this PR include changes in authentication and/or authorization of existing endpoints?
  • Does this change introduce new dependencies that need vetting?
  • Does this change require changes to our infrastructure?
  • Does logging contain sensitive data?
  • Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

  • What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated
    • Spoofing (faking authenticity)
      • Threat T, which could be achieved by A, is mitigated by M
    • Tampering (influence or sabotage the integrity of information, data, or system)
    • Repudiation (the ability to dispute the origin or originator of an action)
    • Information disclosure (data made available to entities who should not have it)
    • Denial of service (make a resource unavailable)
    • Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)
  • Have you ensured logging does not contain sensitive data?
  • Have you received any additional approvals needed for this change?

1.9.20 includes a vulnerable version of log4j.
Copy link

github-actions bot commented Apr 19, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

github-actions bot commented Apr 19, 2024

Test Results

1 111 tests  ±0   1 107 ✅ ±0   4m 56s ⏱️ -1s
  133 suites ±0       4 💤 ±0 
  133 files   ±0       0 ❌ ±0 

Results for commit 044f384. ± Comparison against base commit b3e433d.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 19, 2024

Integration Test Results

 62 files   62 suites   14m 33s ⏱️
389 tests 379 ✅ 10 💤 0 ❌
392 runs  382 ✅ 10 💤 0 ❌

Results for commit 044f384.

♻️ This comment has been updated with latest results.

@snesm snesm added security Work Type label to flag work related to security dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Apr 19, 2024
@snesm snesm marked this pull request as ready for review April 19, 2024 17:03
@snesm snesm requested a review from a team as a code owner April 19, 2024 17:03
Copy link
Collaborator

@mkalish mkalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@snesm snesm enabled auto-merge (squash) April 22, 2024 17:33
@snesm snesm disabled auto-merge April 22, 2024 17:33
@snesm snesm enabled auto-merge (squash) April 22, 2024 17:33
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@snesm snesm merged commit b0a862d into master Apr 22, 2024
16 checks passed
@snesm snesm deleted the snesm/dokkaRollBack branch April 22, 2024 17:56
@david-navapbc
Copy link
Collaborator

I did some digging

  1. attempts to tell gradle to exclude that dependency failed.
  2. the vendor is aware of the issue
  3. I think we should check in on this in about a month or so to see if the vendor has patched. I checked the version of log4j and while yes indeed the jetbrains version removes the net package they left in the chainsaw jar which is another CRITICAL vulnerability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code security Work Type label to flag work related to security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove org.apache.log4j:1.2.17.2 from build chain
3 participants