Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit jitpack use #11938

Merged
merged 11 commits into from
Nov 13, 2023
Merged

Limit jitpack use #11938

merged 11 commits into from
Nov 13, 2023

Conversation

snesm
Copy link
Collaborator

@snesm snesm commented Oct 24, 2023

This PR limits the use of jitpack.io packages to the explicitly included list.

Jitpack risks
Repository content filtering

If you are suggesting a fix for a currently exploitable issue, please disclose the issue to the prime-reportstream team directly outside of GitHub instead of filing a PR, so we may immediately patch the affected systems before a disclosure. See SECURITY.md/Reporting a Vulnerability for more information.

Test Steps:

  1. Include steps to test these changes

Changes

  • Include a comprehensive list of changes in this PR
  • (For web UI changes) Include screenshots/video of changes

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Linked Issues

  • Fixes #issue

To Be Done

Create GitHub issues to track the work remaining, if any

  • #issue

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints?
    • new endpoint A
    • new endpoint B
  • Does this PR include changes in authentication and/or authorization of existing endpoints?
  • Does this change introduce new dependencies that need vetting?
  • Does this change require changes to our infrastructure?
  • Does logging contain sensitive data?
  • Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

  • What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated
    • Spoofing (faking authenticity)
      • Threat T, which could be achieved by A, is mitigated by M
    • Tampering (influence or sabotage the integrity of information, data, or system)
    • Repudiation (the ability to dispute the origin or originator of an action)
    • Information disclosure (data made available to entities who should not have it)
    • Denial of service (make a resource unavailable)
    • Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)
  • Have you ensured logging does not contain sensitive data?
  • Have you received any additional approvals needed for this change?

@github-actions
Copy link

github-actions bot commented Oct 24, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@snesm snesm temporarily deployed to staging October 24, 2023 17:10 — with GitHub Actions Inactive
@snesm snesm added security Work Type label to flag work related to security java Pull requests that update Java code labels Oct 24, 2023
@snesm snesm marked this pull request as ready for review October 24, 2023 17:16
@snesm snesm requested a review from a team as a code owner October 24, 2023 17:16
@github-actions
Copy link

github-actions bot commented Oct 24, 2023

Test Results

1 002 tests  ±0   998 ✔️ ±0   2m 19s ⏱️ -39s
   118 suites ±0       4 💤 ±0 
   118 files   ±0       0 ±0 

Results for commit fcb8e7a. ± Comparison against base commit 27c7845.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 24, 2023

Integration Test Results

  34 files    34 suites   4m 48s ⏱️
282 tests 282 ✔️ 0 💤 0
283 runs  283 ✔️ 0 💤 0

Results for commit fcb8e7a.

♻️ This comment has been updated with latest results.

@snesm snesm temporarily deployed to staging October 24, 2023 17:53 — with GitHub Actions Inactive
Copy link
Collaborator

@jack-h-wang jack-h-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the work to remove mock-fuel entirely has been ticketed as #11928.

@snesm snesm temporarily deployed to staging October 24, 2023 18:36 — with GitHub Actions Inactive
@snesm snesm added the dependencies Pull requests that update a dependency file label Oct 25, 2023
@snesm snesm temporarily deployed to staging October 25, 2023 16:53 — with GitHub Actions Inactive
@snesm
Copy link
Collaborator Author

snesm commented Oct 26, 2023

@mkalish, @victor-chaparro, @arnejduranovic review please

@snesm snesm temporarily deployed to staging October 26, 2023 20:46 — with GitHub Actions Inactive
@snesm snesm temporarily deployed to staging October 30, 2023 16:02 — with GitHub Actions Inactive
@snesm snesm temporarily deployed to staging November 1, 2023 20:00 — with GitHub Actions Inactive
@snesm snesm temporarily deployed to staging November 2, 2023 11:42 — with GitHub Actions Inactive
Copy link

sonarcloud bot commented Nov 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@mkalish mkalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@snesm snesm merged commit 4df06bd into master Nov 13, 2023
5 checks passed
@snesm snesm deleted the snesm/limitJitpack branch November 13, 2023 14:39
Copy link
Collaborator

@arnejduranovic arnejduranovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all fuel references are currently being removed from the code, so I would expect this to get removed once that is done. You can find more info in this ticket: #11928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code security Work Type label to flag work related to security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants