Tim best/apollo take 2

[timbest-cdc]

Related Issue or Background Info

• fixing CVSS mentioned in [Snyk] Security upgrade @apollo/client from 3.3.7 to 3.4.0 #2204
• 3.4.1 includes commit apollographql/apollo-client@d5f1b48 which resolves Uncaught ReferenceError: __DEV__ is not defined after updating to 3.4.0 apollographql/apollo-client#8557

Changes Proposed

• upgrade Apollo to 3.4.1

Additional Information

• 3.4.0 outage thread https://usds.slack.com/archives/C01LTSNKEPP/p1628536766116100

Screenshots / Demos

Checklist for Author and Reviewer

• works in test

UI

• [n/a] Any changes to the UI/UX are approved by design
• [n/a] Any new or updated content (e.g. error messages) are approved by design

Testing

• [n/a] Includes a summary of what a code reviewer should verify

Changes are Backwards Compatible

• [n/a] Database changes are submitted as a separate PR
  • Any new tables that do not contain PII are accompanied by a GRANT SELECT to the no-PHI user
  • Any changes to tables that have custom no-PHI views are accompanied by changes to those views
    (including re-granting permission to the no-PHI user if need be)
  • Liquibase rollback has been tested locally using ./gradlew liquibaseRollbackSQL or liquibaseRollback
• [n/a] GraphQL schema changes are backward compatible with older version of the front-end

Security

• [n/a] Changes with security implications have been approved by a security engineer (changes to authentication, encryption, handling of PII, etc.)
• Any dependencies introduced have been vetted and discussed

Cloud

• [n/a] DevOps team has been notified if PR requires ops support
• If there are changes that cannot be tested locally, this has been deployed to our Azure test environment for verification

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication