Merge pull request #21 from CDJellen/V1.19.6

update tests for new realtime page format
CDJellen · Aug 1, 2023 · 424a1d2 · 424a1d2
2 parents c4b9479 + 9944008
commit 424a1d2
Show file tree

Hide file tree

Showing 9 changed files with 2,047 additions and 417 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -16,7 +16,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest]
-        python-version: [3.7]
+        python-version: ["3.7", "3.10", "3.11"]
     steps:
       - uses: actions/checkout@v2
         with:

diff --git a/.gitignore b/.gitignore
@@ -25,4 +25,4 @@ Brewfile.lock.json
 dist/
 build/
 .ipynb_checkpoints/
-!notebooks/example.ipynb
+!notebooks/overview.ipynb
diff --git a/ndbc_api/api/parsers/station_realtime.py b/ndbc_api/api/parsers/station_realtime.py
@@ -9,7 +9,8 @@ class RealtimeParser(StationParser):
     def available_measurements(cls, response: dict) -> dict:
         if response.get('status') == 200:
             soup = bs4.BeautifulSoup(response.get('body'), 'html.parser')
-            line_items = soup.find_all('li')
+            items = soup.find('section', {"class": "data"})
+            line_items = items.find_all('li')
             return cls._build_available_measurements(line_items=line_items)
         else:
             return dict()

diff --git a/ndbc_api/ndbc_api.py b/ndbc_api/ndbc_api.py
@@ -471,8 +471,8 @@ def _handle_data(data: pd.DataFrame,
             return data.to_dict()
         elif as_df:
             try:
-                return pd.DataFrame().from_dict(data)
-            except (NotImplementedError, ValueError) as e:
+                return pd.DataFrame().from_dict(data, orient='index')
+            except (NotImplementedError, ValueError, TypeError) as e:
                 raise HandlerException(
                     'Failed to convert `pd.DataFrame` to `dict`.') from e
         else:

diff --git a/notebooks/example.ipynb b/notebooks/example.ipynb