Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional HTTP methods #15

Closed
datadavev opened this issue Nov 29, 2023 · 1 comment
Closed

Support additional HTTP methods #15

datadavev opened this issue Nov 29, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@datadavev
Copy link
Collaborator

Although not documented or defined in the ARK spec, the general behavior of the existing predominant ARK resolver is to essentially ignore the HTTP method and simply return the target location.

Modern frameworks expect well defined behavior for HTTP methods, with a default response of 405 if the method is not explicitly supported.

Goal here is to explicitly enable support for HTTP HEAD, PUT, and POST methods in addition to the existing GET method support. In the cases of PUT and POST, the body should be ignored and not loaded to avoid resource consumption attackes.

@datadavev datadavev added the enhancement New feature or request label Nov 29, 2023
@datadavev datadavev self-assigned this Nov 29, 2023
@datadavev
Copy link
Collaborator Author

HEAD and GET requests are supported. POST and PUT may be added if demand, but these can be problematic from a security POV since need to carefully handle a potential barrage of large request bodies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant