Skip to content
This repository has been archived by the owner on Jan 15, 2020. It is now read-only.

Add missing # rubocop:enable comments, and fix any resulting style issues #2

Open
dmolesUC opened this issue Jun 25, 2018 · 1 comment

Comments

@dmolesUC
Copy link

dmolesUC commented Jun 25, 2018

When I first set up RuboCop, I assumed # rubocop:disable was block scoped, but it turns out it's meant to be paired with a matching # rubocop:enable. Without that, it means "disable till further notice".

We've put # rubocop:enable in a few places (e.g. Resource::duplicate_filenames), but there are still a lot of orphan disables out there. At some point we should clean these up, and fix any style issues we discover in code where checks were unintentionally disabled.

@ryscher
Copy link

ryscher commented Jun 27, 2018

I have copied this issue to the new Dryad development tracker at datadryad/dryad-product-roadmap#23 -- it's up to @dmolesUC3 whether it should still be active here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants