Skip to content

Commit

Permalink
[Fix] Fix TestMissingAbstractMethodImpl
Browse files Browse the repository at this point in the history
Summary:
My previous fix for nemo broke one of the QuickTests, that was expecting a
CodeError even in the presence of redeclared base classes.

I've changed the test so that we shouldnt generate a error, and made it check
for that.

Test Plan: fast_tests

Reviewers: qigao, myang

Reviewed By: qigao

CC: ps, mwilliams, qigao

Differential Revision: 341490
  • Loading branch information
mwilliams authored and macvicar committed Oct 18, 2011
1 parent 59bac70 commit 64f4590
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/test/test_code_error.cpp
Expand Up @@ -374,15 +374,14 @@ bool TestCodeError::TestMissingAbstractMethodImpl() {
"}"
"class B implements A {"
"}");
VE(MissingAbstractMethodImpl,
VEN(MissingAbstractMethodImpl,
"<?php "
"if (true) {"
" abstract class A {"
" abstract function foo();"
" }"
"} else {"
" abstract class A {"
" abstract function foo();"
" }"
"}"
"class B extends A {"
Expand Down

0 comments on commit 64f4590

Please sign in to comment.