Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collection vs _type #112

Closed
jduss4 opened this issue Jul 26, 2018 · 1 comment
Closed

collection vs _type #112

jduss4 opened this issue Jul 26, 2018 · 1 comment
Assignees

Comments

@jduss4
Copy link
Contributor

jduss4 commented Jul 26, 2018

The API appears to be using collection instead of _type, and though that's not ideal at least for the meantime we should probably make sure that _type and collection always match.

It could be added during the es_post step of file_type, but then using the -o won't reflect all the contents that are actually being sent to ES. I think instead we might want to change how the various file types are using the transform and output step so that output happens more distinctly.

@jduss4
Copy link
Contributor Author

jduss4 commented Dec 16, 2019

So far we have just been manually adding collection but this should be baked into datura as a check before any documents can be sent.

@jduss4 jduss4 closed this as completed Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant