Skip to content

Commit

Permalink
readme cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
CDonnerer committed Jun 20, 2021
1 parent 812eeda commit 9ab81ba
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
5 changes: 2 additions & 3 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,8 @@ the two models is essentially identical, XGBDistribution is **50x faster**
(timed on both fit and predict steps).

Note that the speed-up will decrease with dataset size, as it is ultimately
limited by the natural gradient computation (via `LAPACK gesv`_, which scales
with O(N^3)), with 1m rows of data ``XGBDistribution`` is still 10x faster than
``NGBRegressor``.
limited by the natural gradient computation (via `LAPACK gesv`_), with 1m rows
of data ``XGBDistribution`` is still 10x faster than ``NGBRegressor``.

.. image:: https://raw.githubusercontent.com/CDonnerer/xgboost-distribution/main/imgs/performance_comparison.png
:align: center
Expand Down
1 change: 0 additions & 1 deletion src/xgboost_distribution/distributions/normal.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ def predict(self, params):

# TODO: this should go elsewhere
Predictions = namedtuple("Predictions", (p for p in self.params))

return Predictions(loc=loc, scale=scale)

def starting_params(self, y):
Expand Down

0 comments on commit 9ab81ba

Please sign in to comment.