Skip to content
This repository has been archived by the owner on Mar 3, 2022. It is now read-only.

rock* matches anything on Genre in the Smart Playlists #1519

Closed
nemonein opened this issue Aug 11, 2019 · 4 comments
Closed

rock* matches anything on Genre in the Smart Playlists #1519

nemonein opened this issue Aug 11, 2019 · 4 comments

Comments

@nemonein
Copy link

nemonein commented Aug 11, 2019

Describe the bug
(It's weird I reported this yesterday, but it's gone..)
'string with an asterisk' matches anything.

To Reproduce

  1. Set Genre in the Smart Playlists, set rock* (Type it, not selecting it from the dropdown menu.)
    Cantata-Smart-playlist-0

  2. Append it to Play Queue
    Cantata-Smart-playlist-1

You can see 'Voyage to India' is selected, of which genre is 'Pop', not related with 'rock'.
I appended the smart playlist after Kenny Wayne Shepherd - The Place you're in.
If the genre is set 'Rock*', or 'Blues*', it works fine. There is Rock, or Blues on the Genre Dropdown menu, but not rock or blues.

Expected behavior
Only rock has to be selected.

Version Info

  • OS: Linux KDE Neon
  • Cantata Version: 2.3.3
  • MPD Version: 0.20.18
@CDrummond
Copy link
Owner

Yeah, I can see the bug. I'm checking for genres's begging with the specified string - but case sensitively. If no match is found, I don't add a genre filter. So, I should be checking case-insensitively, and if none found, don't bother searching for tracks.

CDrummond pushed a commit that referenced this issue Aug 12, 2019
…aylists.

- When matching wildcard genres, if no matches found then use a fake dummy genre so that no tracks will match rules.
Issue #1519
@CDrummond
Copy link
Owner

I've updated the code - yet to test, hence I've not closed this yet.

Until the next release, I suggest you use "Rock*" not "rock*" - so that the case matches,

@nemonein
Copy link
Author

Thank you very much!

@CDrummond
Copy link
Owner

Checked code, and confirmed change works.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants