Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW FEATURE] Trim filters to the minimum in get_mr_filters #50

Closed
zaccharieramzi opened this issue May 3, 2019 · 1 comment
Closed
Assignees
Projects

Comments

@zaccharieramzi
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
I'm always frustrated when using get_mr_filters because it gives me huge filters if I have a huge data_shape (in my case (512, 512)). The convolution then takes so much time.

Describe the solution you'd like
I would like the filters to be trimmed to the minimum so that the convolutions take less time (also it would additionally decrease memory reqs but it's not really an issue).

Describe alternatives you've considered
I could trim them afterwards outside the function, but I think it makes sense to trim them in it.

@sfarrens
Copy link
Contributor

sfarrens commented May 3, 2019

Resolved in #51

@sfarrens sfarrens closed this as completed May 3, 2019
ModOpt-dev automation moved this from ToDo to Done May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
ModOpt-dev
  
Done
Development

No branches or pull requests

2 participants