fix: release savepoint should not return connection (#252)

CECTC · Aug 18, 2022 · 47f1059 · 47f1059
1 parent 63b19cb
commit 47f1059
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 3 deletions.
diff --git a/pkg/executor/read_write_splitting.go b/pkg/executor/read_write_splitting.go
@@ -226,7 +226,6 @@ func (executor *ReadWriteSplittingExecutor) ExecutorComQuery(
 		if !ok {
 			return nil, 0, errors.New("there is no transaction")
 		}
-		defer executor.localTransactionMap.Delete(connectionID)
 		tx = txi.(proto.Tx)
 		if result, err = tx.ReleaseSavepoint(spanCtx, stmt.Name); err != nil {
 			return nil, 0, err

diff --git a/pkg/executor/single_db.go b/pkg/executor/single_db.go
@@ -221,7 +221,6 @@ func (executor *SingleDBExecutor) ExecutorComQuery(
 		if !ok {
 			return nil, 0, errors.New("there is no transaction")
 		}
-		defer executor.localTransactionMap.Delete(connectionID)
 		tx = txi.(proto.Tx)
 		if result, err = tx.ReleaseSavepoint(spanCtx, stmt.Name); err != nil {
 			return nil, 0, err

diff --git a/pkg/sql/tx.go b/pkg/sql/tx.go
@@ -183,7 +183,6 @@ func (tx *Tx) ReleaseSavepoint(ctx context.Context, savepoint string) (result pr
 		return nil, err2.ErrInvalidConn
 	}
 	result, err = tx.conn.Execute(ctx, fmt.Sprintf("RELEASE SAVEPOINT %s", savepoint), false)
-	tx.db.pool.Put(tx.conn)
 	return
 }